Check URDF to distinguish fixed joints from floating joints. Floating… #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… joint are ignored by the publisher.
|
Hi, Anything we can do to help speeding up that merge? Cheers, |
|
This looks good, but can you make the request against the jade branch? |
isucan
added a commit
that referenced
this pull request
Sep 24, 2015
Check URDF to distinguish fixed joints from floating joints. Floating…
|
On further consideration and discussion with @wjwwood, this has a low chance of causing problems, so merged in indigo. Thank you for your fix! |
|
OK great thanks for the merge! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… joints are ignored by the publisher (no segment is added for them).
Fixes #19
Maybe this warning should be modified to make it clear that it happens at the KDL level only, but the robot_state_publisher is still able to distinguish.